Added better error message for OIDC error #5433
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avery-Dunn
reviewed
Aug 11, 2025
bgavrilMS
reviewed
Aug 11, 2025
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/MsalServiceExceptionFactory.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/MsalServiceExceptionFactory.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/MsalServiceExceptionFactory.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Common/Core/Mocks/MockHttpManagerExtensions.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
| { | ||
| var handler = new MockHttpMessageHandler() | ||
| { | ||
| ExpectedUrl = authority + "oauth2/v2.0/token", | ||
| ExpectedUrl = expectedUrl != null? expectedUrl : $"{authority}oauth2/v2.0/token", |
There was a problem hiding this comment.
nit: space between "null" and "?"
Comment on lines
+234
to
+236
| public const string AadAccountTypeAndResourceIncompatibleErrorCode = "AADSTS500207"; | ||
| public const string AadMissingScopeErrorCode = "AADSTS900144"; | ||
|
|
There was a problem hiding this comment.
Can't you re-use the constants from src/client/Microsoft.Identity.Client/Internal/Constants.cs? Wouldn't that be better?
| .Build(); | ||
|
|
||
| httpManager.AddMockHandler( | ||
| CreateOidcHttpHandler(authority + "/" + Constants.WellKnownOpenIdConfigurationPath)); |
There was a problem hiding this comment.
nit: I know you said you didn't want to use string interpolation for just one string character, but I think we should try to be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Fix for #4676
Changes proposed in this request
Adding better message for OICD errors
Testing
Performance impact
Documentation